Home Home > GIT Browse > SLE12-SP4-AZURE
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabian Baumanis <fabian.baumanis@suse.com>2019-06-06 14:51:58 +0200
committerFabian Baumanis <fabian.baumanis@suse.com>2019-06-06 14:51:58 +0200
commit09b7c1c536bd248fdaa6066392a2006b1996646a (patch)
tree8b517a7fa1bbae1b1606ed98a28ad15a280e8ec9
parent439a13f38c8c6776a3d0cfc38aeb36c484874cbd (diff)
of: fix clang -Wunsequenced for be32_to_cpu() (bsc#1135642).
-rw-r--r--patches.fixes/0001-of-fix-clang-Wunsequenced-for-be32_to_cpu.patch59
-rw-r--r--series.conf1
2 files changed, 60 insertions, 0 deletions
diff --git a/patches.fixes/0001-of-fix-clang-Wunsequenced-for-be32_to_cpu.patch b/patches.fixes/0001-of-fix-clang-Wunsequenced-for-be32_to_cpu.patch
new file mode 100644
index 0000000000..504c50247a
--- /dev/null
+++ b/patches.fixes/0001-of-fix-clang-Wunsequenced-for-be32_to_cpu.patch
@@ -0,0 +1,59 @@
+From 440868661f36071886ed360d91de83bd67c73b4f Mon Sep 17 00:00:00 2001
+From: Phong Tran <tranmanphong@gmail.com>
+Date: Tue, 30 Apr 2019 21:56:24 +0700
+Subject: [PATCH] of: fix clang -Wunsequenced for be32_to_cpu()
+Git-commit: 440868661f36071886ed360d91de83bd67c73b4f
+Patch-mainline: v5.2-rc1
+References: bsc#1135642
+
+Now, make the loop explicit to avoid clang warning.
+
+./include/linux/of.h:238:37: warning: multiple unsequenced modifications
+to 'cell' [-Wunsequenced]
+ r = (r << 32) | be32_to_cpu(*(cell++));
+ ^~
+./include/linux/byteorder/generic.h:95:21: note: expanded from macro
+'be32_to_cpu'
+ ^
+./include/uapi/linux/byteorder/little_endian.h:40:59: note: expanded
+from macro '__be32_to_cpu'
+ ^
+./include/uapi/linux/swab.h:118:21: note: expanded from macro '__swab32'
+ ___constant_swab32(x) : \
+ ^
+./include/uapi/linux/swab.h:18:12: note: expanded from macro
+'___constant_swab32'
+ (((__u32)(x) & (__u32)0x000000ffUL) << 24) | \
+ ^
+
+Signed-off-by: Phong Tran <tranmanphong@gmail.com>
+Reported-by: Nick Desaulniers <ndesaulniers@google.com>
+Link: https://github.com/ClangBuiltLinux/linux/issues/460
+Suggested-by: David Laight <David.Laight@ACULAB.COM>
+Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
+Cc: stable@vger.kernel.org
+[robh: fix up whitespace]
+Signed-off-by: Rob Herring <robh@kernel.org>
+Reviewed-by: Fabian Baumanis <fabian.baumanis@suse.com>
+---
+ include/linux/of.h | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/include/linux/of.h b/include/linux/of.h
+index 28797e1a9982..0cf857012f11 100644
+--- a/include/linux/of.h
++++ b/include/linux/of.h
+@@ -234,8 +234,8 @@ extern struct device_node *of_find_all_nodes(struct device_node *prev);
+ static inline u64 of_read_number(const __be32 *cell, int size)
+ {
+ u64 r = 0;
+- while (size--)
+- r = (r << 32) | be32_to_cpu(*(cell++));
++ for (; size--; cell++)
++ r = (r << 32) | be32_to_cpu(*cell);
+ return r;
+ }
+
+--
+2.16.4
+
diff --git a/series.conf b/series.conf
index fc6c285455..2b2256827a 100644
--- a/series.conf
+++ b/series.conf
@@ -22091,6 +22091,7 @@
patches.fixes/ext4-fix-use-after-free-race-with-debug_want_extra_i.patch
patches.fixes/ext4-actually-request-zeroing-of-inode-table-after-g.patch
patches.fixes/ext4-fix-ext4_show_options-for-file-systems-w-o-jour.patch
+ patches.fixes/0001-of-fix-clang-Wunsequenced-for-be32_to_cpu.patch
patches.drivers/ibmvnic-Report-actual-backing-device-speed-and-duple.patch
patches.fixes/openvswitch-add-seqadj-extension-when-NAT-is-used.patch
patches.drivers/net-hns3-remove-resetting-check-in-hclgevf_reset_tas.patch