Home Home > GIT Browse > linux-next
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMian Yousaf Kaukab <ykaukab@suse.de>2019-10-16 14:24:37 +0200
committerMian Yousaf Kaukab <ykaukab@suse.de>2019-10-16 14:24:37 +0200
commit284f3c9059562d3c9145e64d2f4ebae806945b04 (patch)
treee943166e398a487880105f4b9fb79f564967dc73
parent012b115b77048746daeceb852eaeab65eabf9785 (diff)
pinctrl: rockchip: Mark expected switch fall-through
(bsc#1154208).
-rw-r--r--patches.suse/pinctrl-rockchip-Mark-expected-switch-fall-through.patch50
-rw-r--r--series.conf1
2 files changed, 51 insertions, 0 deletions
diff --git a/patches.suse/pinctrl-rockchip-Mark-expected-switch-fall-through.patch b/patches.suse/pinctrl-rockchip-Mark-expected-switch-fall-through.patch
new file mode 100644
index 0000000000..92a6dc0570
--- /dev/null
+++ b/patches.suse/pinctrl-rockchip-Mark-expected-switch-fall-through.patch
@@ -0,0 +1,50 @@
+From: Anders Roxell <anders.roxell@linaro.org>
+Date: Fri, 26 Jul 2019 13:28:12 +0200
+Subject: pinctrl: rockchip: Mark expected switch fall-through
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Git-commit: cd927f140d5199c04270241fb675732275c2d20f
+Patch-mainline: v5.4-rc1
+References: bsc#1154208
+
+When fall-through warnings was enabled by default the following warning
+was starting to show up:
+
+../drivers/pinctrl/pinctrl-rockchip.c: In function ‘rockchip_gpio_set_config’:
+../drivers/pinctrl/pinctrl-rockchip.c:2783:3: warning: this statement may fall
+ through [-Wimplicit-fallthrough=]
+ rockchip_gpio_set_debounce(gc, offset, true);
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+../drivers/pinctrl/pinctrl-rockchip.c:2795:2: note: here
+ default:
+ ^~~~~~~
+
+Rework so that the compiler doesn't warn about fall-through. Add
+'return -ENOTSUPP;' to match the comment.
+
+Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning")
+Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
+Link: https://lore.kernel.org/r/20190726112812.19665-1-anders.roxell@linaro.org
+Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
+Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
+---
+ drivers/pinctrl/pinctrl-rockchip.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
+index 62a622159006..dc0bbf198cbc 100644
+--- a/drivers/pinctrl/pinctrl-rockchip.c
++++ b/drivers/pinctrl/pinctrl-rockchip.c
+@@ -2792,6 +2792,7 @@ static int rockchip_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
+ * still return -ENOTSUPP as before, to make sure the caller
+ * of gpiod_set_debounce won't change its behaviour.
+ */
++ return -ENOTSUPP;
+ default:
+ return -ENOTSUPP;
+ }
+--
+2.16.4
+
diff --git a/series.conf b/series.conf
index 3c5c7437f4..fde74dfe78 100644
--- a/series.conf
+++ b/series.conf
@@ -404,6 +404,7 @@
patches.suse/0001-ipmi-move-message-error-checking-to-avoid-deadlock.patch
patches.suse/platform-chrome-cros_ec_rpmsg-Fix-race-with-host-com.patch
patches.suse/pinctrl-stmfx-update-pinconf-settings.patch
+ patches.suse/pinctrl-rockchip-Mark-expected-switch-fall-through.patch
patches.suse/pinctrl-tegra-Fix-write-barrier-placement-in-pmx_wri.patch
patches.suse/pinctrl-amd-disable-spurious-firing-GPIO-IRQs.patch
patches.suse/pinctrl-meson-gxbb-Fix-wrong-pinning-definition-for-.patch