Home Home > GIT Browse
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2018-10-15 17:51:37 +0200
committerTakashi Iwai <tiwai@suse.de>2018-10-15 17:51:47 +0200
commit5e200467c792a36c3314536bd10df2f1de0e10c7 (patch)
treebe37b9439fb7c88aee6eb68896c415e5c7807e0b
parentb76815cd2fe03cce1d42c6827ce8969a7d0b4b21 (diff)
vti4: Don't count header length twice on tunnel setup
(bsc#1051510).
-rw-r--r--patches.fixes/vti4-Don-t-count-header-length-twice-on-tunnel-setup.patch70
-rw-r--r--series.conf1
2 files changed, 71 insertions, 0 deletions
diff --git a/patches.fixes/vti4-Don-t-count-header-length-twice-on-tunnel-setup.patch b/patches.fixes/vti4-Don-t-count-header-length-twice-on-tunnel-setup.patch
new file mode 100644
index 0000000000..f5d1469c05
--- /dev/null
+++ b/patches.fixes/vti4-Don-t-count-header-length-twice-on-tunnel-setup.patch
@@ -0,0 +1,70 @@
+From dd1df24737727e119c263acf1be2a92763938297 Mon Sep 17 00:00:00 2001
+From: Stefano Brivio <sbrivio@redhat.com>
+Date: Thu, 15 Mar 2018 17:16:27 +0100
+Subject: [PATCH] vti4: Don't count header length twice on tunnel setup
+Git-commit: dd1df24737727e119c263acf1be2a92763938297
+Patch-mainline: v4.16
+References: bsc#1051510
+
+This re-introduces the effect of commit a32452366b72 ("vti4:
+Don't count header length twice.") which was accidentally
+reverted by merge commit f895f0cfbb77 ("Merge branch 'master' of
+git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec").
+
+The commit message from Steffen Klassert said:
+
+ We currently count the size of LL_MAX_HEADER and struct iphdr
+ twice for vti4 devices, this leads to a wrong device mtu.
+ The size of LL_MAX_HEADER and struct iphdr is already counted in
+ ip_tunnel_bind_dev(), so don't do it again in vti_tunnel_init().
+
+And this is still the case now: ip_tunnel_bind_dev() already
+accounts for the header length of the link layer (not
+necessarily LL_MAX_HEADER, if the output device is found), plus
+one IP header.
+
+For example, with a vti device on top of veth, with MTU of 1500,
+the existing implementation would set the initial vti MTU to
+1332, accounting once for LL_MAX_HEADER (128, included in
+hard_header_len by vti) and twice for the same IP header (once
+from hard_header_len, once from ip_tunnel_bind_dev()).
+
+It should instead be 1480, because ip_tunnel_bind_dev() is able
+to figure out that the output device is veth, so no additional
+link layer header is attached, and will properly count one
+single IP header.
+
+The existing issue had the side effect of avoiding PMTUD for
+most xfrm policies, by arbitrarily lowering the initial MTU.
+However, the only way to get a consistent PMTU value is to let
+the xfrm PMTU discovery do its course, and commit d6af1a31cc72
+("vti: Add pmtu handling to vti_xmit.") now takes care of local
+delivery cases where the application ignores local socket
+notifications.
+
+Fixes: b9959fd3b0fa ("vti: switch to new ip tunnel code")
+Fixes: f895f0cfbb77 ("Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec")
+Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
+Acked-by: Sabrina Dubroca <sd@queasysnail.net>
+Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
+Acked-by: Takashi Iwai <tiwai@suse.de>
+
+---
+ net/ipv4/ip_vti.c | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c
+index 51b1669334fe..502e5222eaa9 100644
+--- a/net/ipv4/ip_vti.c
++++ b/net/ipv4/ip_vti.c
+@@ -387,7 +387,6 @@ static int vti_tunnel_init(struct net_device *dev)
+ memcpy(dev->dev_addr, &iph->saddr, 4);
+ memcpy(dev->broadcast, &iph->daddr, 4);
+
+- dev->hard_header_len = LL_MAX_HEADER + sizeof(struct iphdr);
+ dev->mtu = ETH_DATA_LEN;
+ dev->flags = IFF_NOARP;
+ dev->addr_len = 4;
+--
+2.19.0
+
diff --git a/series.conf b/series.conf
index 21ad9495a4..d3ac4ee2d3 100644
--- a/series.conf
+++ b/series.conf
@@ -14031,6 +14031,7 @@
patches.drivers/net-mlx4_core-Fix-memory-leak-while-delete-slave-s-r.patch
patches.suse/vhost-correctly-remove-wait-queue-during-poll-failur.patch
patches.drivers/qede-Fix-barrier-usage-after-tx-doorbell-write.patch
+ patches.fixes/vti4-Don-t-count-header-length-twice-on-tunnel-setup.patch
patches.fixes/vti6-Properly-adjust-vti6-MTU-from-MTU-of-lower-devi.patch
patches.fixes/vti6-Keep-set-MTU-on-link-creation-or-change-validat.patch
patches.fixes/vti6-Fix-dev-max_mtu-setting.patch