Home Home > GIT Browse
diff options
authorMaciej W. Rozycki <macro@linux-mips.org>2008-05-13 19:10:10 +0000
committerGreg Kroah-Hartman <gregkh@suse.de>2008-05-15 07:50:08 -0700
commit69ad365afb26fa2ac1bdb4b166b6cc231251edd8 (patch)
parent6cbde20dcd3ea3df46ac545d59fc4da6b1e9487a (diff)
rtc: rtc_time_to_tm: use unsigned arithmetic
commit 945185a69daa457c4c5e46e47f4afad7dcea734f upstream Date: Mon, 12 May 2008 14:02:24 -0700 Subject: rtc: rtc_time_to_tm: use unsigned arithmetic The input argument to rtc_time_to_tm() is unsigned as well as are members of the output structure. However signed arithmetic is used within for calculations leading to incorrect results for input values outside the signed positive range. If this happens the time of day returned is out of range. Found the problem when fiddling with the RTC and the driver where year was set to an unexpectedly large value like 2070, e.g.: rtc0: setting system clock to 2070-01-01 1193046:71582832:26 UTC (3155760954) while it should be: rtc0: setting system clock to 2070-01-01 00:15:54 UTC (3155760954) Changing types to unsigned fixes the problem. [akpm@linux-foundation.org: remove old-fashioned `register' keyword] Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: David Brownell <david-b@pacbell.net> Cc: Dmitri Vorobiev <dmitri.vorobiev@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-lib.c b/drivers/rtc/rtc-lib.c
index ba795a4db1e9..9f996ec881ce 100644
--- a/drivers/rtc/rtc-lib.c
+++ b/drivers/rtc/rtc-lib.c
@@ -51,7 +51,7 @@ EXPORT_SYMBOL(rtc_year_days);
void rtc_time_to_tm(unsigned long time, struct rtc_time *tm)
- register int days, month, year;
+ unsigned int days, month, year;
days = time / 86400;
time -= days * 86400;