Home Home > GIT Browse
diff options
authorTheodore Ts'o <tytso@mit.edu>2010-06-02 22:04:39 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-13 13:20:18 -0700
commitc60ca6232164fc6abea21bcf3f58172607f491e5 (patch)
parenta234580f5c847eaa59e775469205734c5d94e846 (diff)
ext4: Make sure the MOVE_EXT ioctl can't overwrite append-only files
commit 1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72 upstream. Dan Roseberg has reported a problem with the MOVE_EXT ioctl. If the donor file is an append-only file, we should not allow the operation to proceed, lest we end up overwriting the contents of an append-only file. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 5b14d11438b7..a73ed781752d 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -958,6 +958,9 @@ mext_check_arguments(struct inode *orig_inode,
return -EINVAL;
+ if (IS_IMMUTABLE(donor_inode) || IS_APPEND(donor_inode))
+ return -EPERM;
/* Ext4 move extent does not support swapfile */
if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) {
ext4_debug("ext4 move extent: The argument files should "