Home Home > GIT Browse
diff options
authorColin Ian King <colin.king@canonical.com>2017-11-07 16:45:04 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-12-09 18:42:44 +0100
commite1cadf7c4af2e51f5ac6f078a128d4b71bbaa601 (patch)
parent43135100f117f73177ed8687cdead02772b4e09f (diff)
usb: host: fix incorrect updating of offset
commit 1d5a31582ef046d3b233f0da1a68ae26519b2f0a upstream. The variable temp is incorrectly being updated, instead it should be offset otherwise the loop just reads the same capability value and loops forever. Thanks to Alan Stern for pointing out the correct fix to my original fix. Fix also cleans up clang warning: drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp' is never read Fixes: d49d43174400 ("USB: misc ehci updates") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index b26b96e25a13..8e0b9377644b 100644
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -851,7 +851,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
default: /* unknown */
- temp = (cap >> 8) & 0xff;
+ offset = (cap >> 8) & 0xff;