Home Home > GIT Browse
diff options
authorMarkus Elfring <elfring@users.sourceforge.net>2017-08-17 21:18:01 +0200
committerMike Marshall <hubcap@omnibond.com>2017-09-14 14:58:30 -0400
commit5e273a0e06ee5a50bb9cd40026177feca060c101 (patch)
parent07a258531c7550f8bb481dfe2ec12bb876224487 (diff)
orangefs: Use kcalloc() in orangefs_prepare_cdm_array()
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Mike Marshall <hubcap@omnibond.com>
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c
index 93fe8f8e60f1..5f59917fd631 100644
--- a/fs/orangefs/orangefs-debugfs.c
+++ b/fs/orangefs/orangefs-debugfs.c
@@ -571,9 +571,7 @@ static int orangefs_prepare_cdm_array(char *debug_array_string)
goto out;
- cdm_array =
- kzalloc(cdm_element_count * sizeof(struct client_debug_mask),
+ cdm_array = kcalloc(cdm_element_count, sizeof(*cdm_array), GFP_KERNEL);
if (!cdm_array) {
rc = -ENOMEM;
goto out;