Home Home > GIT Browse
diff options
authorDevin Heitmueller <dheitmueller@kernellabs.com>2009-10-15 01:14:34 -0300
committerGreg Kroah-Hartman <gregkh@suse.de>2009-12-08 11:17:13 -0800
commit72c62be1f9f89d3f60408ab55728237f37911e08 (patch)
parent1ed704825c65b7dd7da77427898d6f08c793c040 (diff)
V4L/DVB (13190): em28xx: fix panic that can occur when starting audio streaming
commit 96fbf771d86a90ff006bc62ca4d4de6474b3de31 upstream. Because the counters were not reset when starting up streaming, they would be reused from the previous run. This can result in cases such that when the second instance of streaming starts up, the "cnt" variable in em28xx_audio_isocirq() can end up being negative, resulting in attempting to write to memory before the start of runtime->dma_area (as well as having a negative number of bytes to copy). Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Michael Krufky <mkrufky@kernellabs.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index ac3292d7646c..95f77b68d49e 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -365,6 +365,11 @@ static int snd_em28xx_hw_capture_free(struct snd_pcm_substream *substream)
static int snd_em28xx_prepare(struct snd_pcm_substream *substream)
+ struct em28xx *dev = snd_pcm_substream_chip(substream);
+ dev->adev.hwptr_done_capture = 0;
+ dev->adev.capture_transfer_done = 0;
return 0;