Home Home > GIT Browse
diff options
authorDmitry Safonov <dima@arista.com>2018-07-27 16:54:44 +0100
committerDavid S. Miller <davem@davemloft.net>2018-07-29 12:50:19 -0700
commit7acf9d4237c46894e0fa0492dd96314a41742e84 (patch)
parent9939a46d90c6c76f4533d534dbadfa7b39dc6acc (diff)
netlink: Do not subscribe to non-existent groups
Make ABI more strict about subscribing to group > ngroups. Code doesn't check for that and it looks bogus. (one can subscribe to non-existing group) Still, it's possible to bind() to all possible groups with (-1) Cc: "David S. Miller" <davem@davemloft.net> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: netdev@vger.kernel.org Signed-off-by: Dmitry Safonov <dima@arista.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 files changed, 1 insertions, 0 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 393573a99a5a..ac805caed2e2 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1008,6 +1008,7 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
if (err)
return err;
+ groups &= (1UL << nlk->ngroups) - 1;
bound = nlk->bound;
if (bound) {