Home Home > GIT Browse
diff options
authorRodrigo Rivas Costa <rodrigorivascosta@gmail.com>2018-04-06 01:09:36 +0200
committerJiri Kosina <jkosina@suse.cz>2018-04-09 09:30:25 +0200
commita955358d54695e4ad9f7d6489a7ac4d69a8fc711 (patch)
parent2e210bbb7429cdcf1a1a3ad00c1bf98bd9bf2452 (diff)
HID: hidraw: Fix crash on HIDIOCGFEATURE with a destroyed device
Doing `ioctl(HIDIOCGFEATURE)` in a tight loop on a hidraw device and then disconnecting the device, or unloading the driver, can cause a NULL pointer dereference. When a hidraw device is destroyed it sets 0 to `dev->exist`. Most functions check 'dev->exist' before doing its work, but `hidraw_get_report()` was missing that check. Cc: stable@vger.kernel.org Signed-off-by: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index fbfcc8009432..b39844adea47 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -192,6 +192,11 @@ static ssize_t hidraw_get_report(struct file *file, char __user *buffer, size_t
int ret = 0, len;
unsigned char report_number;
+ if (!hidraw_table[minor] || !hidraw_table[minor]->exist) {
+ ret = -ENODEV;
+ goto out;
+ }
dev = hidraw_table[minor]->hid;
if (!dev->ll_driver->raw_request) {